Skip to content

[pigeon] Consolidate platform test harnesses part 4 - Windows#2812

Merged
auto-submit[bot] merged 3 commits into
flutter:mainfrom
stuartmorgan-g:pigeon-test-harness-consolidation-windows
Nov 16, 2022
Merged

[pigeon] Consolidate platform test harnesses part 4 - Windows#2812
auto-submit[bot] merged 3 commits into
flutter:mainfrom
stuartmorgan-g:pigeon-test-harness-consolidation-windows

Conversation

@stuartmorgan-g

@stuartmorgan-g stuartmorgan-g commented Nov 15, 2022

Copy link
Copy Markdown
Collaborator

Part of #2803

Moves the Windows tests into the new combined harnesses, updating the test script accordingly and removing the old harnesses.

Pre-launch Checklist

  • I read the Contributor Guide and followed the process outlined there for submitting PRs.
  • I read the Tree Hygiene wiki page, which explains my responsibilities.
  • I read and followed the relevant style guides and ran the auto-formatter. (Unlike the flutter/flutter repo, the flutter/packages repo does use dart format.)
  • I signed the CLA.
  • The title of the PR starts with the name of the package surrounded by square brackets, e.g. [shared_preferences]
  • I listed at least one issue that this PR fixes in the description above.
  • I updated pubspec.yaml with an appropriate new version according to the pub versioning philosophy, or this PR is exempt from version changes.
  • I updated CHANGELOG.md to add a description of the change, following repository CHANGELOG style.
  • I updated/added relevant documentation (doc comments with ///).
  • I added new tests to check the change I am making, or this PR is test-exempt.
  • All existing and new tests are passing.

@stuartmorgan-g stuartmorgan-g added override: no versioning needed Override the check requiring version bumps for most changes override: no changelog needed Override the check requiring CHANGELOG updates for most changes labels Nov 15, 2022
@stuartmorgan-g stuartmorgan-g added the autosubmit Merge PR when tree becomes green via auto submit App label Nov 16, 2022
@auto-submit auto-submit Bot merged commit 6e53179 into flutter:main Nov 16, 2022
creatorpiyush pushed a commit to creatorpiyush/packages that referenced this pull request Jun 10, 2026
@stuartmorgan-g
[pigeon] Consolidate platform test harnesses part 4 - Windows (flutte…
9a322af 
…r#2812)

* Move Windows tests into the new harness

* Shared constant

* autoformat
bisor0627 pushed a commit to bisor0627/packages that referenced this pull request Jun 19, 2026
@stuartmorgan-g
[pigeon] Consolidate platform test harnesses part 4 - Windows (flutte…
cf3e38d 
…r#2812)

* Move Windows tests into the new harness

* Shared constant

* autoformat
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tarrinneal tarrinneal tarrinneal approved these changes
@gaaclarke gaaclarke Awaiting requested review from gaaclarke

Assignees

No one assigned

Labels

autosubmit Merge PR when tree becomes green via auto submit App override: no changelog needed Override the check requiring CHANGELOG updates for most changes override: no versioning needed Override the check requiring version bumps for most changes p: pigeon

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@stuartmorgan-g @tarrinneal